Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: use dot notation for mapCone/mapCocone #2696

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: use dot notation for mapCone/mapCocone #2696

wants to merge 1 commit into from

Conversation

mattrobball
Copy link
Collaborator

Thanks to #2661 we have G.mapCone back. This swiches over globally.

Open in Gitpod

@mattrobball mattrobball added easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR labels Mar 7, 2023
jcommelin
jcommelin approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 7, 2023
bors bot pushed a commit that referenced this pull request Mar 7, 2023
@mattrobball
fix: use dot notation for mapCone/mapCocone (#2696)
43a2e9d 
Thanks to #2661 we have `G.mapCone` back. This swiches over globally.
@bors
Copy link

bors bot commented Mar 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: use dot notation for mapCone/mapCocone [Merged by Bors] - fix: use dot notation for mapCone/mapCocone Mar 7, 2023
@bors bors bot closed this Mar 7, 2023
@bors bors bot deleted the port/switch_to_dot_mapCone branch March 7, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattrobball @jcommelin @semorrison