Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Polynomial.Degree.Lemmas #2723

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Data.Polynomial.Degree.Lemmas #2723

wants to merge 9 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24
feat: port Data.Polynomial.Degree.Lemmas
97c850f
@ChrisHughes24
Initial file copy from mathport
20f3ece
@ChrisHughes24
automated fixes
92bbe1d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ChrisHughes24
some fixes
84ea67c
@ChrisHughes24 ChrisHughes24 added the WIP Work in progress label Mar 8, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed WIP Work in progress labels Mar 8, 2023
jcommelin
jcommelin reviewed Mar 8, 2023
View reviewed changes
Mathlib/Data/Nat/WithBot.lean Outdated
@@ -91,6 +91,10 @@ theorem add_one_le_of_lt {n m : WithBot ℕ} (h : n < m) : n + 1 ≤ m := by
exacts [(not_lt_bot h).elim, WithBot.some_le_some.2 (WithBot.some_lt_some.1 h)]
#align nat.with_bot.add_one_le_of_lt Nat.WithBot.add_one_le_of_lt

--Porting note: new theorem, wasn't necessary in Lean3 but now the coercions are syntactically
--different.
theorem cast_eq_some (n : ℕ) : Nat.cast n = WithBot.some n := rfl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This theorem already exists: Nat.cast_withBot.

jcommelin
jcommelin reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the new theorem, which is a duplicate.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 8, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 8, 2023
@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 8, 2023
@bors
Copy link

bors bot commented Mar 8, 2023

Merge conflict.

@ChrisHughes24
Copy link
Member Author

bors r+

1 similar comment
@ChrisHughes24
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Mar 8, 2023

Already running a review

bors bot pushed a commit that referenced this pull request Mar 8, 2023
@ChrisHughes24
feat: port Data.Polynomial.Degree.Lemmas (#2723)
13b68bd
@bors
Copy link

bors bot commented Mar 8, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Polynomial.Degree.Lemmas [Merged by Bors] - feat: port Data.Polynomial.Degree.Lemmas Mar 8, 2023
@bors bors bot closed this Mar 8, 2023
@bors bors bot deleted the port/Data.Polynomial.Degree.Lemmas branch March 8, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisHughes24 @jcommelin