Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Limits.SmallComplete #2731

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Limits.SmallComplete #2731

wants to merge 5 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Mar 8, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Limits.SmallComplete
6611820
@mo271
Initial file copy from mathport
60381f8
@mo271
automated fixes
d0fa4b1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
first pass
a3c04a1
@mo271 mo271 added the mathlib-port This is a port of a theory file from mathlib. label Mar 8, 2023
@mo271 mo271 added the awaiting-review The author would like community review of the PR label Mar 8, 2023
jcommelin
jcommelin approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 9, 2023
bors bot pushed a commit that referenced this pull request Mar 9, 2023
@mo271
feat: port CategoryTheory.Limits.SmallComplete (#2731)
df68ecb 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 9, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Limits.SmallComplete [Merged by Bors] - feat: port CategoryTheory.Limits.SmallComplete Mar 9, 2023
@bors bors bot closed this Mar 9, 2023
@bors bors bot deleted the port/CategoryTheory.Limits.SmallComplete branch March 9, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @jcommelin @semorrison