Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Topology.Instances.ENNReal #2734

Closed
wants to merge 10 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Mar 9, 2023

API changes:

  • Add HasSum.sum_range_add, sum_add_tsum_nat_add', and tsum_eq_zero_add'. We had these (or stronger) results for topological groups. These versions works for monoids.
  • Rename tendsto_atTop_csupr to tendsto_atTop_csupᵢ, tendsto_atBot_csupr to tendsto_atBot_csupᵢ, tendsto_atBot_cinfi to tendsto_atBot_cinfᵢ, and tendsto_atTop_cinfi to tendsto_atTop_cinfᵢ.
  • Add a shortcut instance for T5Space ENNReal.
  • Add ENNReal.nhdsWithin_Ioi_one_neBot, ENNReal.nhdsWithin_Ioi_nat_neBot, ENNReal.nhdsWithin_Ioi_ofNat_nebot, and ENNReal.nhdsWithin_Iio_neBot.
  • Add ENNReal.hasBasis_nhds_of_ne_top and ENNReal.hasBasis_nhds_of_ne_top'.
  • Add ENNReal.binfᵢ_le_nhds and ENNReal.tendsto_nhds_of_Icc.
  • Use Real.nnabs instead of nnnorm to avoid dependency on analysis.normed.group.basic (forward-port of [Merged by Bors] - chore(topology/instances/ennreal): drop a dependency mathlib#18562).
  • Add ENNReal.tsum_eq_limsup_sum_nat.
  • Add ENNReal.tsum_comp_le_tsum_of_injective, ENNReal.tsum_le_tsum_comp_of_surjective, use them to golf some proofs.
  • Add ENNReal.tsum_bunionᵢ_le_tsum, ENNReal.tsum_unionᵢ_le_tsum. We had versions of these lemmas for finite collections. The proofs for infinite collections are simpler.

Most of these changes were done to fix some long proofs: it was easier for me (@urkud) to add supporting lemmas and golf the proof than to fix the original code.


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@j-loreaux j-loreaux added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 9, 2023
@j-loreaux j-loreaux changed the title feat: port Topology.Instances.Ennreal feat: port Topology.Instances.ENNReal Mar 9, 2023
@urkud
Copy link
Member

urkud commented Mar 9, 2023

Hi, I started porting the same file this morning and forgot to push it to github. Are you working on it? If no, then I'll try to merge our changes and get it done tonight.

@urkud urkud force-pushed the port/Topology.Instances.Ennreal branch from 9249e25 to f2ebb34 Compare March 9, 2023 01:28
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Mar 10, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 10, 2023
bors bot pushed a commit that referenced this pull request Mar 10, 2023
API changes:

* Add `HasSum.sum_range_add`, `sum_add_tsum_nat_add'`, and `tsum_eq_zero_add'`. We had these (or stronger) results for topological groups. These versions works for monoids.
* Rename `tendsto_atTop_csupr` to `tendsto_atTop_csupᵢ`, `tendsto_atBot_csupr` to `tendsto_atBot_csupᵢ`, `tendsto_atBot_cinfi` to `tendsto_atBot_cinfᵢ`, and `tendsto_atTop_cinfi` to `tendsto_atTop_cinfᵢ`.
* Add a shortcut instance for `T5Space ENNReal`.
* Add `ENNReal.nhdsWithin_Ioi_one_neBot`, `ENNReal.nhdsWithin_Ioi_nat_neBot`, `ENNReal.nhdsWithin_Ioi_ofNat_nebot`, and `ENNReal.nhdsWithin_Iio_neBot`.
* Add `ENNReal.hasBasis_nhds_of_ne_top` and `ENNReal.hasBasis_nhds_of_ne_top'`.
* Add `ENNReal.binfᵢ_le_nhds` and `ENNReal.tendsto_nhds_of_Icc`.
* Use `Real.nnabs` instead of `nnnorm` to avoid dependency on `analysis.normed.group.basic` (forward-port of leanprover-community/mathlib#18562).
* Add `ENNReal.tsum_eq_limsup_sum_nat`.
* Add `ENNReal.tsum_comp_le_tsum_of_injective`, `ENNReal.tsum_le_tsum_comp_of_surjective`, use them to golf some proofs.
* Add `ENNReal.tsum_bunionᵢ_le_tsum`, `ENNReal.tsum_unionᵢ_le_tsum`. We had versions of these lemmas for finite collections. The proofs for infinite collections are simpler.

Most of these changes were done to fix some long proofs: it was easier for me (@urkud) to add supporting lemmas and golf the proof than to fix the original code.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Yury Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Mar 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Instances.ENNReal [Merged by Bors] - feat: port Topology.Instances.ENNReal Mar 10, 2023
@bors bors bot closed this Mar 10, 2023
@bors bors bot deleted the port/Topology.Instances.Ennreal branch March 10, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants