New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Topology.Instances.ENNReal #2734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
j-loreaux
added
WIP
Work in progress
mathlib-port
This is a port of a theory file from mathlib.
labels
Mar 9, 2023
j-loreaux
changed the title
feat: port Topology.Instances.Ennreal
feat: port Topology.Instances.ENNReal
Mar 9, 2023
Hi, I started porting the same file this morning and forgot to push it to github. Are you working on it? If no, then I'll try to merge our changes and get it done tonight. |
urkud
force-pushed
the
port/Topology.Instances.Ennreal
branch
from
March 9, 2023 01:28
9249e25
to
f2ebb34
Compare
urkud
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Mar 10, 2023
jcommelin
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
semorrison
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 10, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
API changes: * Add `HasSum.sum_range_add`, `sum_add_tsum_nat_add'`, and `tsum_eq_zero_add'`. We had these (or stronger) results for topological groups. These versions works for monoids. * Rename `tendsto_atTop_csupr` to `tendsto_atTop_csupᵢ`, `tendsto_atBot_csupr` to `tendsto_atBot_csupᵢ`, `tendsto_atBot_cinfi` to `tendsto_atBot_cinfᵢ`, and `tendsto_atTop_cinfi` to `tendsto_atTop_cinfᵢ`. * Add a shortcut instance for `T5Space ENNReal`. * Add `ENNReal.nhdsWithin_Ioi_one_neBot`, `ENNReal.nhdsWithin_Ioi_nat_neBot`, `ENNReal.nhdsWithin_Ioi_ofNat_nebot`, and `ENNReal.nhdsWithin_Iio_neBot`. * Add `ENNReal.hasBasis_nhds_of_ne_top` and `ENNReal.hasBasis_nhds_of_ne_top'`. * Add `ENNReal.binfᵢ_le_nhds` and `ENNReal.tendsto_nhds_of_Icc`. * Use `Real.nnabs` instead of `nnnorm` to avoid dependency on `analysis.normed.group.basic` (forward-port of leanprover-community/mathlib#18562). * Add `ENNReal.tsum_eq_limsup_sum_nat`. * Add `ENNReal.tsum_comp_le_tsum_of_injective`, `ENNReal.tsum_le_tsum_comp_of_surjective`, use them to golf some proofs. * Add `ENNReal.tsum_bunionᵢ_le_tsum`, `ENNReal.tsum_unionᵢ_le_tsum`. We had versions of these lemmas for finite collections. The proofs for infinite collections are simpler. Most of these changes were done to fix some long proofs: it was easier for me (@urkud) to add supporting lemmas and golf the proof than to fix the original code. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Yury Kudryashov <urkud@urkud.name>
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat: port Topology.Instances.ENNReal
[Merged by Bors] - feat: port Topology.Instances.ENNReal
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes:
HasSum.sum_range_add
,sum_add_tsum_nat_add'
, andtsum_eq_zero_add'
. We had these (or stronger) results for topological groups. These versions works for monoids.tendsto_atTop_csupr
totendsto_atTop_csupᵢ
,tendsto_atBot_csupr
totendsto_atBot_csupᵢ
,tendsto_atBot_cinfi
totendsto_atBot_cinfᵢ
, andtendsto_atTop_cinfi
totendsto_atTop_cinfᵢ
.T5Space ENNReal
.ENNReal.nhdsWithin_Ioi_one_neBot
,ENNReal.nhdsWithin_Ioi_nat_neBot
,ENNReal.nhdsWithin_Ioi_ofNat_nebot
, andENNReal.nhdsWithin_Iio_neBot
.ENNReal.hasBasis_nhds_of_ne_top
andENNReal.hasBasis_nhds_of_ne_top'
.ENNReal.binfᵢ_le_nhds
andENNReal.tendsto_nhds_of_Icc
.Real.nnabs
instead ofnnnorm
to avoid dependency onanalysis.normed.group.basic
(forward-port of [Merged by Bors] - chore(topology/instances/ennreal): drop a dependency mathlib#18562).ENNReal.tsum_eq_limsup_sum_nat
.ENNReal.tsum_comp_le_tsum_of_injective
,ENNReal.tsum_le_tsum_comp_of_surjective
, use them to golf some proofs.ENNReal.tsum_bunionᵢ_le_tsum
,ENNReal.tsum_unionᵢ_le_tsum
. We had versions of these lemmas for finite collections. The proofs for infinite collections are simpler.Most of these changes were done to fix some long proofs: it was easier for me (@urkud) to add supporting lemmas and golf the proof than to fix the original code.