Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Monoidal.End #2759

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Monoidal.End #2759

wants to merge 11 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Mar 9, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Monoidal.End
f675aab
@mo271
Initial file copy from mathport
50b6dcb
@mo271
automated fixes
0b6864c 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
first pass
c60aca2
@mo271
manual: comments
2905eaa
@mo271 mo271 added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 9, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 9, 2023 •
edited

TODOs:

  • Fix obj_μ_inv_app
  • handle simpNF linters
  • remove lines with ambiguous notation warning

@mo271 mo271 added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Mar 9, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 9, 2023

Please check especially if the simpNF linter is treated correctly

@jcommelin
Copy link
Member

What is the reason that you add nolint simpNF? Please document this for each case in a porting note.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 10, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 10, 2023

nolint simpNF

What is the reason that you add nolint simpNF? Please document this for each case in a porting note.

I added porting note in all 4 cases. It seems that it thinks that it can use the lemme itself somehow in simp, or a _assoc version of that lemma. Perhaps this is a bug in the linter?!

@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 10, 2023
jcommelin
jcommelin approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 10, 2023
bors bot pushed a commit that referenced this pull request Mar 10, 2023
@mo271
feat: port CategoryTheory.Monoidal.End (#2759)
aa92e2f 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 10, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Mar 10, 2023
@mo271
feat: port CategoryTheory.Monoidal.End (#2759)
64a06a0 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Monoidal.End [Merged by Bors] - feat: port CategoryTheory.Monoidal.End Mar 10, 2023
@bors bors bot closed this Mar 10, 2023
@bors bors bot deleted the port/CategoryTheory.Monoidal.End branch March 10, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @jcommelin @semorrison