Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port CategoryTheory.Additive.Basic #2797

Closed
wants to merge 7 commits into from
Closed

feat: port CategoryTheory.Additive.Basic #2797

wants to merge 7 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port CategoryTheory.Additive.Basic
a5f29d5
@Parcly-Taxel
Initial file copy from mathport
1a78083
@Parcly-Taxel
automated fixes
d0ebc96 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 11, 2023
jcommelin
jcommelin approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 11, 2023
bors bot pushed a commit that referenced this pull request Mar 11, 2023
@Parcly-Taxel
feat: port CategoryTheory.Additive.Basic (#2797)
728db0d 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 11, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Mar 11, 2023
@Parcly-Taxel
feat: port CategoryTheory.Additive.Basic (#2797)
85a1ea5 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 11, 2023

Build failed (retrying...):

  • Build

@ChrisHughes24
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Mar 11, 2023

Canceled.

@ChrisHughes24
Copy link
Member

bors r+

@ChrisHughes24
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Mar 11, 2023

Canceled.

@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge This PR has been sent to bors. easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 11, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed awaiting-author A reviewer has asked the author a question or requested changes easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 11, 2023
@ChrisHughes24 ChrisHughes24 removed awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 13, 2023
@ChrisHughes24 ChrisHughes24 added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 13, 2023
@Parcly-Taxel
Copy link
Collaborator Author

Parcly-Taxel commented Mar 13, 2023 •
edited

The problem with simpNF appears to be leanprover/lean4#2055; cf. #2769

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 13, 2023
@semorrison
Copy link
Contributor

I'm going to remove awaiting-review and add blocked-by-core-PR, as it seems we won't be able to merge this until there's a fix for leanprover/lean4#2055. If you think of a way around this, please feel free to update the labels.

@semorrison semorrison added blocked-by-core-PR and removed awaiting-review The author would like community review of the PR labels Mar 27, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 23, 2023
@joelriou joelriou mentioned this pull request Apr 30, 2023
Closed
@Parcly-Taxel Parcly-Taxel deleted the port/CategoryTheory.Additive.Basic branch May 2, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
blocked-by-core-PR mathlib-port This is a port of a theory file from mathlib. merge-conflict The PR has a merge conflict with master, and needs manual merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Parcly-Taxel @ChrisHughes24 @semorrison @jcommelin @joelriou