Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Control.Bitraversable.Basic #2804

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Control.Bitraversable.Basic #2804

wants to merge 5 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port Control.Bitraversable.Basic
901557c
@Parcly-Taxel
Initial file copy from mathport
abea82f
@Parcly-Taxel
automated fixes
203995c 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
How pure is this fix?
e4b8d7a
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 11, 2023
jcommelin
jcommelin approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 11, 2023
bors bot pushed a commit that referenced this pull request Mar 11, 2023
@Parcly-Taxel
feat: port Control.Bitraversable.Basic (#2804)
575293a 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Control.Bitraversable.Basic [Merged by Bors] - feat: port Control.Bitraversable.Basic Mar 11, 2023
@bors bors bot closed this Mar 11, 2023
@bors bors bot deleted the port/Control.Bitraversable.Basic branch March 11, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @jcommelin @semorrison