Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Finiteness #2811

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Finiteness #2811

wants to merge 18 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24
feat: port RingTheory.Finiteness
2651978
@ChrisHughes24
Initial file copy from mathport
5daf194
@ChrisHughes24
automated fixes
e27a739 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ChrisHughes24
first pass
d450ee5
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Mar 11, 2023
@ChrisHughes24 ChrisHughes24 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Mar 15, 2023
@mattrobball
Copy link
Collaborator

Still has eta

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Mar 17, 2023
@casavaca
Copy link
Collaborator

@Parcly-Taxel This should not be awaiting-review because it contains set_option synthInstance.etaExperiment true in which is for local testing only.

@casavaca casavaca removed the awaiting-review The author would like community review of the PR label Mar 17, 2023
@mattrobball
remove eta
36606d8
@mattrobball
fix long line; abbrev help
a62a14c 
why the need for dsimp on an abbrev?
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed eta-experiment labels Mar 17, 2023
@Parcly-Taxel Parcly-Taxel added enhancement New feature or request and removed enhancement New feature or request labels Mar 18, 2023
@jcommelin
Copy link
Member

@casavaca that is not strictly true. If all other options have been tried, but we can't get the PR to compile without etaExperiment than we sometimes make an exception.

jcommelin
jcommelin reviewed Mar 18, 2023
View reviewed changes
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
Mathlib/RingTheory/Finiteness.lean Show resolved Hide resolved
jcommelin
jcommelin approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 18, 2023
bors bot pushed a commit that referenced this pull request Mar 18, 2023
@ChrisHughes24 @Ruben-VandeVelde
@mattrobball @jcommelin
feat: port RingTheory.Finiteness (#2811)
e5ec18f 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Mar 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Finiteness [Merged by Bors] - feat: port RingTheory.Finiteness Mar 18, 2023
@bors bors bot closed this Mar 18, 2023
@bors bors bot deleted the port/RingTheory.Finiteness branch March 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ChrisHughes24 @mattrobball @casavaca @jcommelin @semorrison @Parcly-Taxel @Ruben-VandeVelde