Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port RingTheory.Polynomial.ScaleRoots #2841

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: Port RingTheory.Polynomial.ScaleRoots #2841

wants to merge 6 commits into from

Conversation

casavaca
Copy link
Collaborator

@casavaca casavaca commented Mar 13, 2023 •
edited by github-actions bot

@casavaca casavaca added blocked-by-other-PR This PR depends on another PR which is still in the queue. mathlib-port This is a port of a theory file from mathlib. labels Mar 13, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Mar 13, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@casavaca
feat: port RingTheory.Polynomial.ScaleRoots
65e4d76
@casavaca
Initial file copy from mathport
1851a47
@casavaca
automated fixes
b8366c3 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@casavaca
Small fixes
8493a6f
@casavaca
golf
cb2f7e1
@casavaca casavaca force-pushed the port/RingTheory.Polynomial.ScaleRoots branch from 6b84d11 to cb2f7e1 Compare March 13, 2023 08:19
@casavaca casavaca added awaiting-CI WIP Work in progress and removed awaiting-CI labels Mar 13, 2023
@casavaca casavaca added awaiting-CI awaiting-review The author would like community review of the PR and removed WIP Work in progress awaiting-CI labels Mar 13, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 13, 2023
bors bot pushed a commit that referenced this pull request Mar 13, 2023
@casavaca
feat: Port RingTheory.Polynomial.ScaleRoots (#2841)
54ea1b1
@bors
Copy link

bors bot commented Mar 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port RingTheory.Polynomial.ScaleRoots [Merged by Bors] - feat: Port RingTheory.Polynomial.ScaleRoots Mar 13, 2023
@bors bors bot closed this Mar 13, 2023
@bors bors bot deleted the port/RingTheory.Polynomial.ScaleRoots branch March 13, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casavaca @semorrison @ChrisHughes24