Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.CharP.Pi #2874

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Algebra.CharP.Pi #2874

wants to merge 5 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port Algebra.CharP.Pi
0ab9bc7
@Parcly-Taxel
Initial file copy from mathport
1d64ed5
@Parcly-Taxel
automated fixes
c35d855 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix error
1d6040d
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 14, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 14, 2023
@bors
Copy link

bors bot commented Mar 14, 2023

Merge conflict.

@ChrisHughes24
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 14, 2023
@Parcly-Taxel
feat: port Algebra.CharP.Pi (#2874)
dd39f47 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.CharP.Pi [Merged by Bors] - feat: port Algebra.CharP.Pi Mar 14, 2023
@bors bors bot closed this Mar 14, 2023
@bors bors bot deleted the port/Algebra.CharP.Pi branch March 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Parcly-Taxel @ChrisHughes24