Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.MvPolynomial.Monad #2887

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.MvPolynomial.Monad #2887

wants to merge 6 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Mar 14, 2023 •
edited by github-actions bot

@j-loreaux j-loreaux added WIP Work in progress blocked-by-other-PR This PR depends on another PR which is still in the queue. mathlib-port This is a port of a theory file from mathlib. labels Mar 14, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Mar 15, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@j-loreaux j-loreaux force-pushed the port/Data.MvPolynomial.Monad branch from 66019fa to ed9384e Compare March 15, 2023 14:23
@j-loreaux j-loreaux added help-wanted The author needs attention to resolve issues and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Mar 15, 2023
@semorrison semorrison mentioned this pull request Mar 15, 2023
Closed
@semorrison
Copy link
Contributor

leanprover-community/mathlib#18593 will force us to pause on this one to do Data.MvPolynomial.Variables first.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 18, 2023
@j-loreaux
feat: port Data.MvPolynomial.Monad
12cadc6
@j-loreaux
Initial file copy from mathport
e3c8bc1
@j-loreaux
automated fixes
2cb3493 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@j-loreaux
mostly done
0861d81
@j-loreaux
two sorries left
0a19ac4
@j-loreaux j-loreaux force-pushed the port/Data.MvPolynomial.Monad branch from ed9384e to 0a19ac4 Compare March 21, 2023 18:16
@j-loreaux j-loreaux removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 21, 2023
jcommelin
jcommelin approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@bors
Copy link

bors bot commented Apr 3, 2023

👎 Rejected by label

@semorrison semorrison added the ready-to-merge This PR has been sent to bors. label Apr 3, 2023
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress ready-to-merge This PR has been sent to bors. labels Apr 3, 2023
@semorrison
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Apr 4, 2023
@j-loreaux @jcommelin
feat: port Data.MvPolynomial.Monad (#2887)
3ec9411 
- [x] depends on: #2861 
- [x] depends on: #2886



Co-authored-by: Johan Commelin <johan@commelin.net>
@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 4, 2023
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Apr 4, 2023
@bors
Copy link

bors bot commented Apr 4, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.MvPolynomial.Monad [Merged by Bors] - feat: port Data.MvPolynomial.Monad Apr 4, 2023
@bors bors bot closed this Apr 4, 2023
@bors bors bot deleted the port/Data.MvPolynomial.Monad branch April 4, 2023 01:14
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@j-loreaux @jcommelin @MonadMaverick
feat: port Data.MvPolynomial.Monad (#2887)
a45c154 
- [x] depends on: #2861 
- [x] depends on: #2886



Co-authored-by: Johan Commelin <johan@commelin.net>
MonadMaverick pushed a commit to MonadMaverick/mathlib4 that referenced this pull request Apr 9, 2023
@j-loreaux @jcommelin @MonadMaverick
feat: port Data.MvPolynomial.Monad (leanprover-community#2887)
22eb65a 
- [x] depends on: leanprover-community#2861 
- [x] depends on: leanprover-community#2886



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-loreaux @semorrison @jcommelin