[Merged by Bors] - chore: forward port leanprover-community/mathlib#18575 #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
eric-wieser
commented
Mar 15, 2023
| @@ -469,14 +456,13 @@ theorem coe_mul (f g : P1 →ᵃ[k] P1) : ⇑(f * g) = f ∘ g := | |||
| #align affine_map.coe_mul AffineMap.coe_mul | |||
|
|
|||
| @[simp] | |||
| theorem coe_one : ⇑(1 : P1 →ᵃ[k] P1) = id k P1 := | |||
3 tasks
eric-wieser
added
awaiting-review
awaiting-CI
mathlib3-pair
eric-wieser
commented
Mar 15, 2023
| @@ -853,7 +831,7 @@ theorem homothety_apply_same (c : P1) (r : k) : homothety c r c = c := | |||
|
|
|||
| theorem homothety_mul_apply (c : P1) (r₁ r₂ : k) (p : P1) : | |||
| homothety c (r₁ * r₂) p = homothety c r₁ (homothety c r₂ p) := by | |||
| simp [homothety_apply, mul_smul] | |||
| simp only [homothety_apply, mul_smul, vadd_vsub] | |||
There was a problem hiding this comment.
This proof was ported without modification the first time, but for whatever reason needs more help after this re-port
eric-wieser
commented
Mar 15, 2023
Comment on lines
502
to
503
| -- porting note: `simp` needs a placeholder for the `β` argument to `Set.mem_vsub` | ||
| simp only [Set.mem_vsub (β := _), Set.mem_image, |
There was a problem hiding this comment.
This is deeply weird
|
maintainer merge |
1 similar comment
|
maintainer merge |
isn't it |
|
I don't want to merge my own PR without the eyes of another maintainer. I posted again to try and wake up the bot, but it seems to be having github API issues, which we're working on resolving) |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
This somewhat re-ports the file from scratch (by manually cleaning up the mathport output to remove all the meta comments), as lots of workarounds were added in #2570 to deal with coercion issues. All proof changes are restoring the mathport proofs, except for small modifications to use `simp [(foo)]` instead of `simp [foo]` or `simp` (where `foo` was already a `simp` lemma). leanprover-community/mathlib#18575
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
This ran into many of the problems that #2899 did, where `simp` would fail but `simp [(foo)]` or `simp [foo _]` would succeed. Co-authored-by: Moritz Doll <moritz.doll@googlemail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somewhat re-ports the file from scratch (by manually cleaning up the mathport output to remove all the meta comments), as lots of workarounds were added in #2570 to deal with coercion issues.
All proof changes are restoring the mathport proofs, except for small modifications to use
simp [(foo)]instead ofsimp [foo]orsimp(wherefoowas already asimplemma).leanprover-community/mathlib#18575