Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feat: to_additive warns if simps is not applied to the additive version #2908

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Feat: to_additive warns if simps is not applied to the additive version #2908

wants to merge 2 commits into from

Conversation

fpvandoorn
Copy link
Member

  • Note: the changes in the test file are unrelated, but that removes some linter warnings

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands awaiting-CI and removed awaiting-CI labels Mar 15, 2023
@urkud
Copy link
Member

urkud commented Mar 16, 2023

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 16, 2023
bors bot pushed a commit that referenced this pull request Mar 16, 2023
@fpvandoorn
Feat: to_additive warns if simps is not applied to the additive versi…
9b4b031 
…on (#2908)

* Note: the changes in the test file are unrelated, but that removes some linter warnings
@bors
Copy link

bors bot commented Mar 16, 2023

Build failed:

  • Build

@urkud
Copy link
Member

urkud commented Mar 16, 2023

Build failed
bors r-
bors d+

@bors
Copy link

bors bot commented Mar 16, 2023

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud added delegated and removed ready-to-merge This PR has been sent to bors. labels Mar 16, 2023
@fpvandoorn
Copy link
Member Author

The error message looks like some connection issue. Let's retry

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 16, 2023
bors bot pushed a commit that referenced this pull request Mar 16, 2023
@fpvandoorn
Feat: to_additive warns if simps is not applied to the additive versi…
7829ab2 
…on (#2908)

* Note: the changes in the test file are unrelated, but that removes some linter warnings
@fpvandoorn fpvandoorn mentioned this pull request Mar 16, 2023
Closed
1 task
@bors
Copy link

bors bot commented Mar 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: to_additive warns if simps is not applied to the additive version [Merged by Bors] - Feat: to_additive warns if simps is not applied to the additive version Mar 16, 2023
@bors bors bot closed this Mar 16, 2023
@bors bors bot deleted the toadditivewarnsimps branch March 16, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @urkud