Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Preadditive.OfBiproducts #2939

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Preadditive.OfBiproducts #2939

wants to merge 7 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Mar 16, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Preadditive.OfBiproducts
1728945
@mo271
Initial file copy from mathport
a48d6dc
@mo271
automated fixes
6bec98f 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
starting
90ab628
@mo271
fix h₁
81e88f3
@mo271 mo271 added mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues labels Mar 16, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 16, 2023 •
edited

The only thing left is a non-working reassoc_of in distrib

@mo271 mo271 removed the help-wanted The author needs attention to resolve issues label Mar 17, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Mar 17, 2023

Adding the two haves in the two proofs seemed necessary, because type inference wasn't working without it. Also it is faster this way, I think

@mo271 mo271 added the awaiting-review The author would like community review of the PR label Mar 17, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 17, 2023
bors bot pushed a commit that referenced this pull request Mar 17, 2023
@mo271
feat: port CategoryTheory.Preadditive.OfBiproducts (#2939)
d2cf8db 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Preadditive.OfBiproducts [Merged by Bors] - feat: port CategoryTheory.Preadditive.OfBiproducts Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the port/CategoryTheory.Preadditive.OfBiproducts branch March 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mo271 @ChrisHughes24