Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: forward port mathlib#18571 #2941

Closed
wants to merge 2 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Mar 16, 2023


Open in Gitpod

@ericrbg ericrbg added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Mar 16, 2023
@eric-wieser
Copy link
Member

You'll need to update the SHA in the file too (which you can easily pull from https://leanprover-community.github.io/mathlib-port-status/file/topology/order/basic, or from the latest mathport output)

@ericrbg
Copy link
Collaborator Author

ericrbg commented Mar 17, 2023

like this? sorry, I haven't done much porting in a bit!

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 17, 2023
bors bot pushed a commit that referenced this pull request Mar 17, 2023
Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: forward port mathlib#18571 [Merged by Bors] - chore: forward port mathlib#18571 Mar 17, 2023
@bors bors bot closed this Mar 17, 2023
@bors bors bot deleted the frontier_Icc branch March 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-CI mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants