[Merged by Bors] - feat: port Algebra.TrivSqZeroExt #2951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Note that the note on the port comment wiki is out of date; the PR to wait for has made it through mathport already. The main difficulty here comes from the fact that Lean can no longer work out the type of the zero in `(r • 0 : M)` due to `•` being `HSMul`. The rest of the port is just adding instance names, and one cases where `cases n` resulted in an unwanted `Nat.zero` where using `match n` gives a better `0`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the note on the port comment wiki is out of date; the PR to wait for has made it through mathport already.
The main difficulty here comes from the fact that Lean can no longer work out the type of the zero in
(r • 0 : M)due to•beingHSMul. The rest of the port is just adding instance names, and one cases wherecases nresulted in an unwantedNat.zerowhere usingmatch ngives a better0.