Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.MvPolynomial.Variables #2961

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.MvPolynomial.Variables #2961

wants to merge 7 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24
feat: port Data.MvPolynomial.Variables
8889a59
@ChrisHughes24
Initial file copy from mathport
283e44d
@ChrisHughes24
automated fixes
8bd86c8 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ChrisHughes24 ChrisHughes24 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 17, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Mar 17, 2023
dupuisf
dupuisf reviewed Mar 18, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Data/MvPolynomial/Variables.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 18, 2023

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Mar 18, 2023
@RemyDegenne @dupuisf
Update Mathlib/Data/MvPolynomial/Variables.lean
148f2c6 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@RemyDegenne
Copy link
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 18, 2023
bors bot pushed a commit that referenced this pull request Mar 18, 2023
@ChrisHughes24 @RemyDegenne
feat: port Data.MvPolynomial.Variables (#2961)
45b747d 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@bors
Copy link

bors bot commented Mar 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.MvPolynomial.Variables [Merged by Bors] - feat: port Data.MvPolynomial.Variables Mar 18, 2023
@bors bors bot closed this Mar 18, 2023
@bors bors bot deleted the port/Data.MvPolynomial.Variables branch March 18, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisHughes24 @RemyDegenne @dupuisf @semorrison