Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Multiplicity #2962

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Multiplicity #2962

wants to merge 8 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Mar 17, 2023

Open in Gitpod

@mattrobball
feat: port RingTheory.Multiplicity
4de17bb
@mattrobball
Initial file copy from mathport
3f6d334
@mattrobball
automated fixes
f6eb790 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@mattrobball
fix on first pass
e18b80a
@xroblot xroblot added the mathlib-port This is a port of a theory file from mathlib. label Mar 17, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Mar 17, 2023

@mattrobball Looks like we started to work on the same file at the same time. I hope I didn't messed up with your PR.

In any case, this file is all yours now ;)

@mattrobball
Copy link
Collaborator

@xroblot Sorry! I have to step away for a bit. I pushed where I got to. Feel free to work on it please.

@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Mar 18, 2023
RemyDegenne
RemyDegenne reviewed Mar 18, 2023
View reviewed changes
Mathlib/RingTheory/Multiplicity.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Multiplicity.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Multiplicity.lean Outdated Show resolved Hide resolved
@RemyDegenne
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 18, 2023
bors bot pushed a commit that referenced this pull request Mar 18, 2023
@mattrobball @RemyDegenne
feat: port RingTheory.Multiplicity (#2962)
c9e6ed7 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@bors
Copy link

bors bot commented Mar 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Multiplicity [Merged by Bors] - feat: port RingTheory.Multiplicity Mar 18, 2023
@bors bors bot closed this Mar 18, 2023
@bors bors bot deleted the port/RingTheory.Multiplicity branch March 18, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyDegenne RemyDegenne RemyDegenne left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @mattrobball @RemyDegenne