[Merged by Bors] - feat: port Data.Nat.Multiplicity #2974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
mattrobball
added
mathlib-port
mattrobball
added
awaiting-review
RemyDegenne
reviewed
Mar 19, 2023
Mathlib/Data/Nat/Multiplicity.lean
Outdated
| refine' binary_rec _ _ | ||
| · contradiction | ||
| refine' binaryRec _ _ | ||
| · exact fun h => False.elim <| h rfl | ||
| · intro b n ih h | ||
| by_cases hn : n = 0 | ||
| · subst hn | ||
| simp at h | ||
| simp [h, one_right h2.not_unit] |
There was a problem hiding this comment.
This is a non-terminal simp, right? Please replace it by a simp only
There was a problem hiding this comment.
That must have been from mathlib3 but it is fixed now.
RemyDegenne
added
awaiting-author
|
Thanks! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started but got pulled away. Feel free to jump in.
