[Merged by Bors] - feat: port Data.Set.Sups #2991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
mo271
added
help-wanted
2 tasks
|
Can you check what is going on here, @YaelDillies? In mathlib at commit e96bdfbd, I get a similar problem, that I see in mathlib4: Does this need be fixed in mathlib first? |
|
It's because there needs to be a forward port of the dependencies first. I am writing it later today. |
mo271
added
WIP
semorrison
added
blocked-by-other-PR
|
This PR/issue depends on:
|
Parcly-Taxel
added
awaiting-review
mo271
removed
the
awaiting-review
|
This should fix the simpNF lints, but I'm unsure if they were justified. Please take a close look and possibly revert the last two commits and fix the simpNF lint complaints differntly. |
|
@Parcly-Taxel, please be sure something is ready for review before marking it as such. Here there were still some plain mathport output in the file along with linters to appease. |
mo271
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2023
- [x] depends on: leanprover-community/mathlib#18172 - [x] depends on: #2991 Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
- [x] depends on: leanprover-community/mathlib#18172 - [x] depends on: #2991 Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
- [x] depends on: leanprover-community/mathlib#18172 - [x] depends on: #2991 Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set.image2_image2_image2_comm#2992