Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.ChainOfDivisors #3056

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.ChainOfDivisors #3056

wants to merge 12 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Mar 23, 2023 •
edited by github-actions bot
Loading

@ChrisHughes24 ChrisHughes24 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues blocked-by-other-PR This PR depends on another PR to Mathlib and removed WIP Work in progress help-wanted The author needs attention to resolve issues labels Mar 23, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 7, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 13, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Apr 20, 2023

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ChrisHughes24 @semorrison
Update Mathlib/RingTheory/ChainOfDivisors.lean
59afd65 
Co-authored-by: Scott Morrison <scott@tqft.net>
@Parcly-Taxel Parcly-Taxel removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Apr 20, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@ChrisHughes24
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 20, 2023
bors bot pushed a commit that referenced this pull request Apr 20, 2023
@ChrisHughes24 @Ruben-VandeVelde
feat: port RingTheory.ChainOfDivisors (#3056)
c80a95d 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Apr 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.ChainOfDivisors [Merged by Bors] - feat: port RingTheory.ChainOfDivisors Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
@bors bors bot deleted the port/RingTheory.ChainOfDivisors branch April 20, 2023 15:22
kbuzzard pushed a commit that referenced this pull request Apr 22, 2023
@ChrisHughes24 @Ruben-VandeVelde @kbuzzard
feat: port RingTheory.ChainOfDivisors (#3056)
0143fcb 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request May 10, 2023
@ChrisHughes24 @Ruben-VandeVelde
feat: port RingTheory.ChainOfDivisors (#3056)
f4af9a6 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisHughes24 @semorrison @Parcly-Taxel @Ruben-VandeVelde