[Merged by Bors] - feat: port NumberTheory.Padics.PadicNumbers #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
int-y1
commented
Mar 25, 2023
int-y1
commented
int-y1
added
WIP
|
Lots of different errors remain. |
Ruben-VandeVelde
force-pushed
the
port/NumberTheory.Padics.PadicNumbers
branch
from
e70c8c2
to
dca812e
Compare
semorrison
added
the
merge-conflict
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Ruben-VandeVelde
force-pushed
the
port/NumberTheory.Padics.PadicNumbers
branch
from
5934926
to
5f6b7a6
Compare
semorrison
removed
the
merge-conflict
jjaassoonn
added
awaiting-review
ChrisHughes24
removed
the
help-wanted
jcommelin
reviewed
May 21, 2023
| #align padic Padic | ||
|
|
||
| -- mathport name: «exprℚ_[ ]» | ||
| /-- notation for p-padic rationals -/ |
There was a problem hiding this comment.
Suggested change
| /-- notation for p-padic rationals -/ | |
| /-- notation for p-adic rationals -/ |
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 22, 2023
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.