feat: Port Algebra.Category.Ring.Basic #3105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamtopaz
commented
Mar 26, 2023
•
adamtopaz
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
adamtopaz
added
help-wanted
|
I got the file to build, but I am still quite unhappy with several things. I had to use some hacks in many places, and some automation didn't work when it should have. I added porting notes for all of these issue. I won't have much time to look after this PR for the rest of this week, so I will tag it with |
|
Okay, I agree, this is pretty bad. :-( |
This was referenced May 11, 2023
bors bot
pushed a commit
that referenced
this pull request
May 12, 2023
I think the ports * #2902 (MonCat) * #3036 (GroupCat) * #3260 (ModuleCat) didn't quite get things right, and also have some variation between them. This PR tries to straighten things out. Major changes: * Have the coercion to type be via `X.\a`, and put attribute `@[coe]` on this. * Make sure the coercion from morphisms to functions means that simp lemmas about the underlying bundled morphisms apply directly. * This means we drop lemmas like ``` lemma Hom.map_mul {X Y : MonCat} (f : X ⟶ Y) (x y : X) : ((forget MonCat).map f) (x * y) = f x * f y ``` * But at the expense of adding lemmas like ``` lemma coe_comp {X Y Z : MonCat} {f : X ⟶ Y} {g : Y ⟶ Z} : (f ≫ g : X → Z) = g ∘ f := rfl ``` Overall I'm pretty happy, and it allows me to unstick the long stuck #3105. This is not everything I want to do to refactor these files, but once I was satisfied that I can move forward with RingCat, I want to get this merged so we can unblock porting progress. I'll promise to come back to this soon! :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
bors bot
pushed a commit
that referenced
this pull request
May 14, 2023
This is a replacement for #3105 which makes use of the refactors proposed in #3900. I'm happy to just merge this into #3105 if that's preferred, but since it depends on a refactor I thought I'd keep it separate for now. - [x] depends on: #3900 [](https://gitpod.io/from-referrer/) Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com> Co-authored-by: adamtopaz <github@adamtopaz.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Closing, as this was replaced by #3901. |
](https://gitpod.io/from-referrer/){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.