Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Order.Hom.Esakia #3108

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: port Topology.Order.Hom.Esakia #3108

wants to merge 15 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 26, 2023

Open in Gitpod

@urkud
feat: port Topology.Order.Hom.Esakia
8760a42
@urkud
Initial file copy from mathport
b099929
@urkud
automated fixes
7bfd513 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Partially fix
e256de4
@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 29, 2023
@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label Apr 16, 2023
@int-y1
Copy link
Collaborator

int-y1 commented May 6, 2023 •
edited by mattrobball

todo:

  • simpNF linter on EsakiaHom.toFun_eq_coe EsakiaHom.coe_id_continuousOrderHom EsakiaHom.coe_comp_continuousOrderHom

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 6, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues awaiting-review The author would like community review of the PR labels Jun 5, 2023
@mattrobball
Merge branch 'master' into port/Topology.Order.Hom.Esakia
87c9262
@mattrobball
rework coercion
7ef7c3f 
the coercion from EsakiaHom to ContinuousOrderHom was an odd duck
compared to the similar ones in this file. The ContinuousOrderHom
constructor was directly exposed in the coercise resulting in simp
rewriting the fields and simpNF complaining. Introduced
EsakiaHomClass.toContinuousOrderHom which wrapped this constructor
and things behave uniformly.
@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Jun 6, 2023
jcommelin
jcommelin approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 7, 2023
bors bot pushed a commit that referenced this pull request Jun 7, 2023
@urkud @int-y1 @mattrobball
feat: port Topology.Order.Hom.Esakia (#3108)
5caec4b 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Order.Hom.Esakia [Merged by Bors] - feat: port Topology.Order.Hom.Esakia Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the port/Topology.Order.Hom.Esakia branch June 7, 2023 01:19
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @int-y1
@mattrobball @qawbecrdtey
feat: port Topology.Order.Hom.Esakia (leanprover-community#3108)
126d92c 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @int-y1 @jcommelin @semorrison @mattrobball