Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Localization.Module #3129

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Localization.Module #3129

wants to merge 5 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24
feat: port RingTheory.Localization.Module
7df23f7
@ChrisHughes24
Initial file copy from mathport
e43d35d
@ChrisHughes24
automated fixes
0c2aa03 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ChrisHughes24
fix red
a831f8c
@ChrisHughes24
naming
4bfa9f7
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 27, 2023
jcommelin
jcommelin approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 29, 2023
bors bot pushed a commit that referenced this pull request Mar 29, 2023
@ChrisHughes24
feat: port RingTheory.Localization.Module (#3129)
87a0508
@bors
Copy link

bors bot commented Mar 29, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Localization.Module [Merged by Bors] - feat: port RingTheory.Localization.Module Mar 29, 2023
@bors bors bot closed this Mar 29, 2023
@bors bors bot deleted the port/RingTheory.Localization.Module branch March 29, 2023 09:12
joelriou pushed a commit that referenced this pull request Mar 30, 2023
@ChrisHughes24 @joelriou
feat: port RingTheory.Localization.Module (#3129)
5f78f52
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@ChrisHughes24 @MonadMaverick
feat: port RingTheory.Localization.Module (#3129)
5349e37
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@ChrisHughes24 @MonadMaverick
feat: port RingTheory.Localization.Module (#3129)
8303e3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @jcommelin @semorrison