Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Nat.Factorization.PrimePow #3157

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.Nat.Factorization.PrimePow #3157

wants to merge 7 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port Data.Nat.Factorization.PrimePow
a4bdf21
@Parcly-Taxel
Initial file copy from mathport
0de4b1f
@Parcly-Taxel
automated fixes
c8245bc 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix most errors
18dbd68
@Parcly-Taxel Parcly-Taxel added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 28, 2023
Parcly-Taxel and others added 2 commits March 29, 2023 03:02
@Parcly-Taxel @kmill
Update Mathlib/Data/Nat/Factorization/PrimePow.lean
0aafff3 
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@Parcly-Taxel
Unused variable
31e8625
@Parcly-Taxel Parcly-Taxel added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Mar 28, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 29, 2023
bors bot pushed a commit that referenced this pull request Mar 29, 2023
@Parcly-Taxel
feat: port Data.Nat.Factorization.PrimePow (#3157)
e040592 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 29, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Nat.Factorization.PrimePow [Merged by Bors] - feat: port Data.Nat.Factorization.PrimePow Mar 29, 2023
@bors bors bot closed this Mar 29, 2023
@bors bors bot deleted the port/Data.Nat.Factorization.PrimePow branch March 29, 2023 02:38
joelriou pushed a commit that referenced this pull request Mar 30, 2023
@Parcly-Taxel @joelriou
feat: port Data.Nat.Factorization.PrimePow (#3157)
cf4a5c6 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill left review comments

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @semorrison @kmill