[Merged by Bors] - Feat: Port/Data.Seq.Seq #3187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
arienmalec
added
WIP
arienmalec
added
help-wanted
This comment was marked as duplicate.
This comment was marked as duplicate.
eric-wieser
reviewed
Apr 2, 2023
Komyyy
added
awaiting-CI
and removed
help-wanted
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
Port of `Data.Seq.Seq` following Mathlib3 refactor to avoid `Seq` overload. Down to two issues: - [x] `bind_ret` goes like Mathlib3 right up to the last line but doesn't close (I've tried the full Mathlib3 `simp` invocation to no avail. - [x] `bind_assoc` has issues with single `match` lines gumming up the works, which should `dsimp` away but don't Co-authored-by: Komyyy <pol_tta@outlook.jp>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of
Data.Seq.Seqfollowing Mathlib3 refactor to avoidSeqoverload.Down to two issues:
bind_retgoes like Mathlib3 right up to the last line but doesn't close (I've tried the full Mathlib3simpinvocation to no avail.bind_assochas issues with singlematchlines gumming up the works, which shoulddsimpaway but don't