Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: re-port Algebra.CharP.Basic #3191

Closed
wants to merge 8 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Mar 30, 2023

This forward-ports changes from leanprover-community/mathlib#11364

One unrelated downstream file times out, presumably due to the import graph subtly changing.


This is the last file from mathlib#11364. The other files are:

Open in Gitpod

@joneugster joneugster added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Mar 30, 2023
@Parcly-Taxel Parcly-Taxel changed the title chore: forward port Algebra.CharP.Basic chore: report Algebra.CharP.Basic Mar 30, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

Mathlib/Algebra/CharP/Basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 31, 2023

✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser changed the title chore: report Algebra.CharP.Basic chore: re-port Algebra.CharP.Basic Mar 31, 2023
@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Mar 31, 2023
@joneugster
Copy link
Collaborator Author

Thx Jeremy for fixing the newline + by. I'll leave the porting notes in for now. They don't hurt anybody and can always be dropped later.

bors r+

bors bot pushed a commit that referenced this pull request Mar 31, 2023
This forward-ports changes from leanprover-community/mathlib#11364



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
bors bot pushed a commit that referenced this pull request Mar 31, 2023
This forward-ports changes from leanprover-community/mathlib#11364



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 31, 2023
bors bot pushed a commit that referenced this pull request Mar 31, 2023
This forward-ports changes from leanprover-community/mathlib#11364



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 31, 2023

Build failed:

@eric-wieser
Copy link
Member

Can you merge master?

@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Apr 1, 2023
This forward-ports changes from leanprover-community/mathlib#11364

One unrelated downstream file times out, presumably due to the import graph subtly changing.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: re-port Algebra.CharP.Basic [Merged by Bors] - chore: re-port Algebra.CharP.Basic Apr 1, 2023
@bors bors bot closed this Apr 1, 2023
@bors bors bot deleted the forward-port-algebra.char_p.basic branch April 1, 2023 16:28
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
This forward-ports changes from leanprover-community/mathlib#11364

One unrelated downstream file times out, presumably due to the import graph subtly changing.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
This forward-ports changes from leanprover-community/mathlib#11364

One unrelated downstream file times out, presumably due to the import graph subtly changing.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants