Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.MvPolynomial.WeightedHomogeneous #3192

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.MvPolynomial.WeightedHomogeneous #3192

wants to merge 9 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port RingTheory.MvPolynomial.WeightedHomogeneous
cc84b2f
@Parcly-Taxel
Initial file copy from mathport
f1402ce
@Parcly-Taxel
automated fixes
f9bddad 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix all but 5 errors
855aa04
@Parcly-Taxel Parcly-Taxel added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 30, 2023
@mo271
Copy link
Collaborator

mo271 commented Mar 31, 2023

This leaves 3 errors

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Mar 31, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 31, 2023
bors bot pushed a commit that referenced this pull request Mar 31, 2023
@Parcly-Taxel @mo271
feat: port RingTheory.MvPolynomial.WeightedHomogeneous (#3192)
c04b29d 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Mar 31, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.MvPolynomial.WeightedHomogeneous [Merged by Bors] - feat: port RingTheory.MvPolynomial.WeightedHomogeneous Mar 31, 2023
@bors bors bot closed this Mar 31, 2023
@bors bors bot deleted the port/RingTheory.MvPolynomial.WeightedHomogeneous branch March 31, 2023 11:02
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @mo271 @MonadMaverick
feat: port RingTheory.MvPolynomial.WeightedHomogeneous (#3192)
90cafd9 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @mo271 @MonadMaverick
feat: port RingTheory.MvPolynomial.WeightedHomogeneous (#3192)
cd6673f 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @mo271 @ChrisHughes24