Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Adjoin.Tower #3210

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Adjoin.Tower #3210

wants to merge 4 commits into from

Conversation

mattrobball
Copy link
Collaborator

A pleasant reprieve
Open in Gitpod

@mattrobball
feat: port RingTheory.Adjoin.Tower
06a08c3
@mattrobball
Initial file copy from mathport
aff8cb6
@mattrobball
automated fixes
f270145 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mattrobball
fix errors; lint; align names
ef53522
@mattrobball mattrobball added mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR labels Mar 31, 2023
dupuisf
dupuisf reviewed Apr 2, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 2, 2023
bors bot pushed a commit that referenced this pull request Apr 2, 2023
@mattrobball
feat: port RingTheory.Adjoin.Tower (#3210)
445481f
@bors
Copy link

bors bot commented Apr 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Adjoin.Tower [Merged by Bors] - feat: port RingTheory.Adjoin.Tower Apr 2, 2023
@bors bors bot closed this Apr 2, 2023
@bors bors bot deleted the port/RingTheory.Adjoin.Tower branch April 2, 2023 14:26
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@mattrobball @MonadMaverick
feat: port RingTheory.Adjoin.Tower (#3210)
ded5846
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@mattrobball @MonadMaverick
feat: port RingTheory.Adjoin.Tower (#3210)
1fbc607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattrobball @dupuisf @semorrison