Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Cast of natural is measurable #3226

Closed
wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Apr 2, 2023
@@ -275,6 +275,19 @@ theorem measurable_const' {f : β → α} (hf : ∀ x y, f x = f y) : Measurable
apply hf
#align measurable_const' measurable_const'

-- porting note: Attribute not yet supported
-- @[measurability]
theorem measurable_nat_cast [NatCast α] (n : ℕ) : Measurable (n : β → α) :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be natCast? I realize we're inconsistent within mathlib4, but perhaps you have a preference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Apr 2, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Apr 2, 2023
@YaelDillies
Copy link
Collaborator Author

I'm going with natCast, intCast for now.

@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Apr 2, 2023
Match leanprover-community/mathlib#18676



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Cast of natural is measurable [Merged by Bors] - feat: Cast of natural is measurable Apr 3, 2023
@bors bors bot closed this Apr 3, 2023
@bors bors bot deleted the measurable_nat_cast branch April 3, 2023 00:48
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
Match leanprover-community/mathlib#18676



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
MonadMaverick pushed a commit to MonadMaverick/mathlib4 that referenced this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants