Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Matrix.DualNumber #3239

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.Matrix.DualNumber #3239

wants to merge 6 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Apr 3, 2023

Open in Gitpod

@mo271
feat: port Data.Matrix.DualNumber
d34a89d
@mo271
Initial file copy from mathport
cfa2ff8
@mo271
automated fixes
5271c73 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
fix file
5237a12
@mo271
auto: naming
ff5afde
@mo271 mo271 added mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR labels Apr 3, 2023
eric-wieser
eric-wieser approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 3, 2023
@bors
Copy link

bors bot commented Apr 3, 2023

Merge conflict.

@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Apr 3, 2023
@mo271 @eric-wieser
feat: port Data.Matrix.DualNumber (#3239)
dfd333b 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Matrix.DualNumber [Merged by Bors] - feat: port Data.Matrix.DualNumber Apr 3, 2023
@bors bors bot closed this Apr 3, 2023
@bors bors bot deleted the port/Data.Matrix.DualNumber branch April 3, 2023 11:15
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@mo271 @eric-wieser @MonadMaverick
feat: port Data.Matrix.DualNumber (#3239)
aecd188 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@mo271 @eric-wieser @MonadMaverick
feat: port Data.Matrix.DualNumber (#3239)
dcf56e4 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @eric-wieser @semorrison