Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Data.Matrix.CharP #3250

Closed
wants to merge 4 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Apr 3, 2023


Open in Gitpod

@mo271 mo271 added the mathlib-port This is a port of a theory file from mathlib. label Apr 3, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Apr 3, 2023

having

convert @scalar_inj n _ _ _ _ _ (@Nat.cast R NonAssocSemiring.toNatCast k) 0

is a bit ugly, but it didn't work without providing the arguments explicitly.

@mo271 mo271 added the awaiting-review The author would like community review of the PR label Apr 3, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 4, 2023
bors bot pushed a commit that referenced this pull request Apr 4, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Apr 4, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Matrix.CharP [Merged by Bors] - feat: port Data.Matrix.CharP Apr 4, 2023
@bors bors bot closed this Apr 4, 2023
@bors bors bot deleted the port/Data.Matrix.CharP branch April 4, 2023 13:02
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
MonadMaverick pushed a commit to MonadMaverick/mathlib4 that referenced this pull request Apr 9, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants