[Merged by Bors] - feat: port LinearAlgebra.StdBasis #3264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ruben-VandeVelde
commented
Apr 4, 2023
Ruben-VandeVelde
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Ruben-VandeVelde
added
help-wanted
eric-wieser
reviewed
Apr 5, 2023
| exact | ||
| funext fun i => | ||
| ((@supᵢ_pos _ _ _ fun h => range <| std_basis R φ i) <| Finset.mem_univ i).symm | ||
| convert top_unique (infᵢ_emptyset.ge.trans <| infᵢ_ker_proj_le_supᵢ_range_stdBasis R φ _) |
There was a problem hiding this comment.
I think convert might have syntax for naming the variables it intros now.
There was a problem hiding this comment.
Not in the documentation. Let me know what it is if you find it.
eric-wieser
reviewed
Apr 5, 2023
Mathlib/LinearAlgebra/StdBasis.lean
Outdated
| show (∑ i in I, stdBasis R φ i (b i)) = b by | ||
| ext i | ||
| rw [Finset.sum_apply, ← stdBasis_same R φ i (b i)] | ||
| refine' Finset.sum_eq_single i (fun j hjI ne => stdBasis_ne _ _ _ _ ne.symm _) _ |
There was a problem hiding this comment.
One thing that might help here is using refine instead and replacing only the relevant _ with ?_
There was a problem hiding this comment.
What would this help with?
There was a problem hiding this comment.
I already pushed that fix. It tells lean which metavariables it can turn into goals and which it has to solve immediately.
Ruben-VandeVelde
added
awaiting-review
1 task
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.