Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Algebra.ContinuousAffineMap #3277

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Topology.Algebra.ContinuousAffineMap #3277

wants to merge 12 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Apr 5, 2023

Open in Gitpod

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Apr 5, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 5, 2023 •
edited

todo:

  • 3 norm_cast errors
  • instance : Neg failed to synthesize ContinuousNeg W
  • 2 errors involving toContinuousAffineMap

@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels May 10, 2023
int-y1 and others added 8 commits May 10, 2023 02:40
@int-y1
Initial file copy from mathport
598c69c
@int-y1
automated fixes
dd0dc7c 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix most
6bd4d01
@int-y1
style
5190b7d
@int-y1
fix coe_smul
301f078
@ChrisHughes24 @int-y1
some fixes
e074b9b
@mcdoll @int-y1
norm cast
13ed396
@int-y1
clean up
808d949
@int-y1 int-y1 force-pushed the port/Topology.Algebra.ContinuousAffineMap branch from 316bc0e to 808d949 Compare May 10, 2023 09:42
@int-y1
Copy link
Collaborator Author

int-y1 commented May 10, 2023 •
edited by mattrobball

todo:

  • instance : Coe (P →A[R] Q) C(P, Q) cannot find synthesization order for instance

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 30, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 7, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 7, 2023
@mattrobball
Copy link
Collaborator

There appears to be some global GitHub issues with pull requests. The commits making this green are pushed to origin but it appears things are not propagating here at the moment.

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 7, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jun 8, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Jun 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 8, 2023
@int-y1 @ChrisHughes24
@mcdoll @mattrobball
feat: port Topology.Algebra.ContinuousAffineMap (#3277)
b8c7685 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Algebra.ContinuousAffineMap [Merged by Bors] - feat: port Topology.Algebra.ContinuousAffineMap Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/Topology.Algebra.ContinuousAffineMap branch June 8, 2023 07:31
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @ChrisHughes24
@mcdoll @mattrobball @qawbecrdtey
feat: port Topology.Algebra.ContinuousAffineMap (leanprover-community…
127c3f1 
…#3277)

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @mattrobball @semorrison @ChrisHughes24 @mcdoll