Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Algebra.FilterBasis #3279

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Topology.Algebra.FilterBasis #3279

wants to merge 9 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Apr 5, 2023

Open in Gitpod

@int-y1
feat: port Topology.Algebra.FilterBasis
3d8e6f9
@int-y1
Initial file copy from mathport
de4ed79
@int-y1
automated fixes
ce7c76f 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix most
4805ccf
@int-y1
code style
d32c4bc
@int-y1
docs
3d7d516
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Apr 5, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 5, 2023 •
edited by ChrisHughes24

todo:

  • attribute [to_additive] errors
  • ModuleFilterBasis.continuousSMul type mismatch at B.smul
  • ModuleFilterBasis.ofBases failed to synthesize instance TopologicalSpace R

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Apr 5, 2023
dupuisf
dupuisf reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/Algebra/FilterBasis.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Apr 5, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Apr 5, 2023
@Parcly-Taxel @dupuisf
Update Mathlib/Topology/Algebra/FilterBasis.lean
cb6de1b 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 6, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 6, 2023
@int-y1 @Parcly-Taxel @ChrisHughes24
feat: port Topology.Algebra.FilterBasis (#3279)
2f26603 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.Algebra.FilterBasis [Merged by Bors] - feat: port Topology.Algebra.FilterBasis Apr 6, 2023
@bors bors bot closed this Apr 6, 2023
@bors bors bot deleted the port/Topology.Algebra.FilterBasis branch April 6, 2023 08:05
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@int-y1 @Parcly-Taxel
@ChrisHughes24 @MonadMaverick
feat: port Topology.Algebra.FilterBasis (#3279)
748b385 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@int-y1 @Parcly-Taxel
@ChrisHughes24 @MonadMaverick
feat: port Topology.Algebra.FilterBasis (#3279)
ad431cc 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @dupuisf @semorrison @ChrisHughes24 @Parcly-Taxel