Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Idempotents.KaroubiKaroubi #3298

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Idempotents.KaroubiKaroubi #3298

wants to merge 19 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Apr 6, 2023 •
edited by github-actions bot

@joelriou
feat: port CategoryTheory.Idempotents.Basic
dc54c64
@joelriou
Initial file copy from mathport
caafb58
@joelriou
automated fixes
1ade08d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou
it compiles
d0846e3
@joelriou
feat: port CategoryTheory.Idempotents.Karoubi
feaf9a7
@joelriou
Initial file copy from mathport
4da4d59
@joelriou
automated fixes
f93afd6 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou
Merge branch 'port/CategoryTheory.Idempotents.Basic' into port/Catego…
0309e7d 
…ryTheory.Idempotents.Karoubi
@joelriou
it compiles
e0a86a1
@joelriou
feat: port CategoryTheory.Idempotents.KaroubiKaroubi
288b3d3
@joelriou
Initial file copy from mathport
b4bab2a
@joelriou
automated fixes
8db3be1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 6, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Apr 6, 2023
@joelriou joelriou removed the WIP Work in progress label Apr 6, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 6, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 6, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Apr 6, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

ChrisHughes24
ChrisHughes24 reviewed Apr 6, 2023
View reviewed changes
Mathlib/CategoryTheory/Idempotents/KaroubiKaroubi.lean Outdated
variable (C : Type _) [Category C]

-- porting note: added to ease automation
@[simp]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be reassoc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yes, indeed it should. I have just added it.

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 6, 2023
bors bot pushed a commit that referenced this pull request Apr 6, 2023
@joelriou @Parcly-Taxel
feat: port CategoryTheory.Idempotents.KaroubiKaroubi (#3298)
b56224c 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Idempotents.KaroubiKaroubi [Merged by Bors] - feat: port CategoryTheory.Idempotents.KaroubiKaroubi Apr 6, 2023
@bors bors bot closed this Apr 6, 2023
@bors bors bot deleted the port/CategoryTheory.Idempotents.KaroubiKaroubi branch April 6, 2023 16:53
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@joelriou @Parcly-Taxel @MonadMaverick
feat: port CategoryTheory.Idempotents.KaroubiKaroubi (#3298)
86502fc 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@joelriou @Parcly-Taxel @MonadMaverick
feat: port CategoryTheory.Idempotents.KaroubiKaroubi (#3298)
883c31a 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 ChrisHughes24 left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelriou @semorrison @ChrisHughes24 @Parcly-Taxel