Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Groupoid.FreeGroupoid #3347

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Groupoid.FreeGroupoid #3347

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 9, 2023

Open in Gitpod

@urkud
feat: port CategoryTheory.Groupoid.FreeGroupoid
e3ce452
@urkud
Initial file copy from mathport
c079005
@urkud
automated fixes
fa9c658 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Partially fix
d47d35d
@urkud
Fix more
dc783d7
@urkud urkud added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Apr 9, 2023
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels May 17, 2023
jcommelin
jcommelin approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 18, 2023
bors bot pushed a commit that referenced this pull request May 18, 2023
@urkud @jjaassoonn
feat: port CategoryTheory.Groupoid.FreeGroupoid (#3347)
0d5e1c8 
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
@bors
Copy link

bors bot commented May 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Groupoid.FreeGroupoid [Merged by Bors] - feat: port CategoryTheory.Groupoid.FreeGroupoid May 18, 2023
@bors bors bot closed this May 18, 2023
@bors bors bot deleted the port/CategoryTheory.Groupoid.FreeGroupoid branch May 18, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @jcommelin @semorrison @jjaassoonn