Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: support irreducible_def in to_additive #3399

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: support irreducible_def in to_additive #3399

wants to merge 6 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Apr 11, 2023 •
edited by github-actions bot
Loading

This resolves all of the irreducible_def todos I could find.

Open in Gitpod

@gebner gebner added the t-meta Tactics, attributes or user commands label Apr 11, 2023
@gebner gebner changed the title Evenbetterirreddef feat: support irreducible_def in to_additive Apr 11, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR to Mathlib label Apr 11, 2023
digama0
digama0 reviewed Apr 12, 2023
View reviewed changes
Mathlib/Tactic/Eqns.lean Outdated Show resolved Hide resolved
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Apr 12, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 12, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 12, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 12, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 12, 2023
@gebner gebner added the awaiting-review The author would like community review of the PR label Apr 13, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 13, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 13, 2023
@fpvandoorn
Copy link
Member

LGTM
Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 14, 2023
bors bot pushed a commit that referenced this pull request Apr 14, 2023
@gebner
feat: support irreducible_def in to_additive (#3399)
27e0a79
@bors
Copy link

bors bot commented Apr 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: support irreducible_def in to_additive [Merged by Bors] - feat: support irreducible_def in to_additive Apr 14, 2023
@bors bors bot closed this Apr 14, 2023
@bors bors bot deleted the evenbetterirreddef branch April 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gebner @semorrison @fpvandoorn @digama0