Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.Asymptotics.AsymptoticEquivalent #3417

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Analysis.Asymptotics.AsymptoticEquivalent #3417

wants to merge 11 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Apr 13, 2023

Open in Gitpod

@int-y1
feat: port Analysis.Asymptotics.AsymptoticEquivalent
6117bc0
@int-y1
Initial file copy from mathport
ef4ec4d
@int-y1
automated fixes
cf0c458 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix
edff70b
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 13, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 13, 2023 •
edited by Parcly-Taxel

todo:

  • IsEquivalent.smul error with rewriting ← smul_sub

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Apr 13, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 14, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 15, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Apr 16, 2023
jcommelin
jcommelin approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 17, 2023
bors bot pushed a commit that referenced this pull request Apr 17, 2023
@int-y1 @Parcly-Taxel @ADedecker
feat: port Analysis.Asymptotics.AsymptoticEquivalent (#3417)
de1c73a 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: ADedecker <anatolededecker@gmail.com>
@bors
Copy link

bors bot commented Apr 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Analysis.Asymptotics.AsymptoticEquivalent [Merged by Bors] - feat: port Analysis.Asymptotics.AsymptoticEquivalent Apr 17, 2023
@bors bors bot closed this Apr 17, 2023
@bors bors bot deleted the port/Analysis.Asymptotics.AsymptoticEquivalent branch April 17, 2023 07:01
semorrison pushed a commit that referenced this pull request May 10, 2023
@int-y1 @Parcly-Taxel @ADedecker
feat: port Analysis.Asymptotics.AsymptoticEquivalent (#3417)
dc26f0f 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: ADedecker <anatolededecker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @jcommelin @semorrison @Parcly-Taxel @ADedecker