[Merged by Bors] - feat: port pi_fin.reflect instance
#3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
help-wanted
4 tasks
eric-wieser
force-pushed
the
eric-wieser/port-Fin.reflect
branch
from
88add10
to
2f9f625
Compare
|
This PR/issue depends on:
|
|
@eric-wieser I've pushed a commit that makes it as it gets right now. |
…to eric-wieser/port-Fin.reflect
eric-wieser
commented
Apr 14, 2023
| let x : Fin 0 → ℕ := ![] | ||
| let .true ← isDefEq (toExpr x) q((![] : Fin 0 → ℕ)) | failure | ||
|
|
||
| #eval do |
There was a problem hiding this comment.
Is there a better pattern than #eval do here?
There was a problem hiding this comment.
I would like to define #assert (which can run MetaM code), but haven't done so yet. AFAIK this is as good as it gets for now.
There was a problem hiding this comment.
By the way, isDefEq doesn't do typechecking, so it might be good to do typechecks for toExpr and toTypeExpr. See https://github.com/leanprover-community/mathlib4/blob/master/test/DeriveToExpr.lean
eric-wieser
commented
Apr 14, 2023
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
This was skipped during the initial port of this file. There are some golfing discussions [here on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/unquoteExpr.3A.20inst.E2.9C.9D.C2.B2.2E2.20.3A.20Expr/near/349273797) that we could revisit later Co-authored-by: Gabriel Ebner <gebner@gebner.org>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
pi_fin.reflect instancepi_fin.reflect instance
semorrison
pushed a commit
that referenced
this pull request
May 10, 2023
This was skipped during the initial port of this file. There are some golfing discussions [here on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/unquoteExpr.3A.20inst.E2.9C.9D.C2.B2.2E2.20.3A.20Expr/near/349273797) that we could revisit later Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was skipped during the initial port of this file.
There are some golfing discussions here on Zulip that we could revisit later
ToExprderiving handler #3215