Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.Convex.Body #3431

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Analysis.Convex.Body #3431

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 14, 2023

Open in Gitpod

@urkud
feat: port Analysis.Convex.Body
776b329
@urkud
Initial file copy from mathport
7c638f4
@urkud
automated fixes
6051477 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Fix compile
46662fe
@urkud
auto: naming
79a4457
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Apr 14, 2023
dupuisf
dupuisf reviewed Apr 15, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Analysis/Convex/Body.lean Outdated
Comment on lines 118 to 119
@[simp] -- porting note: todo: add `norm_cast`
theorem coe_add (K L : ConvexBody V) : (↑(K + L) : Set V) = (K : Set V) + L :=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to make these porting notes more explicit. I guess the idea is that norm_cast is not present in mathlib3 but should have been, but during the port it's better to stick to mathlib3 behavior and fix it later -- right? In this case how about "porting note: add norm_cast; we leave it out for now to reproduce mathlib3 behavior."

Copy link
Member Author

@urkud urkud Apr 15, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If` someone wants this PR to be merged before Wednesday, April 19: feel free to update the porting notes as suggested & merge. I have a few deadlines in a row right now... I'll fix it in a few minutes.

@bors
Copy link

bors bot commented Apr 15, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Apr 15, 2023
@urkud
Copy link
Member Author

urkud commented Apr 16, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 16, 2023
bors bot pushed a commit that referenced this pull request Apr 16, 2023
@urkud
feat: port Analysis.Convex.Body (#3431)
f25608f
@bors
Copy link

bors bot commented Apr 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Analysis.Convex.Body [Merged by Bors] - feat: port Analysis.Convex.Body Apr 16, 2023
@bors bors bot closed this Apr 16, 2023
@bors bors bot deleted the port/Analysis.Convex.Body branch April 16, 2023 16:35
semorrison pushed a commit that referenced this pull request May 10, 2023
@urkud
feat: port Analysis.Convex.Body (#3431)
e2bc205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @dupuisf @semorrison