Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.FreeModule.PID #3434

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.FreeModule.PID #3434

wants to merge 19 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Apr 14, 2023

Open in Gitpod

@xroblot
feat: port LinearAlgebra.FreeModule.Pid
a0eba45
@xroblot
Initial file copy from mathport
2c1dd65
@xroblot
automated fixes
20fb08d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 14, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 14, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 18, 2023
@Parcly-Taxel Parcly-Taxel changed the title feat: port LinearAlgebra.FreeModule.Pid feat: port LinearAlgebra.FreeModule.PID Apr 20, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 20, 2023
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 20, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 20, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Apr 20, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 20, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Apr 20, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 20, 2023
@xroblot @Parcly-Taxel
feat: port LinearAlgebra.FreeModule.PID (#3434)
a0ec959 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.FreeModule.PID [Merged by Bors] - feat: port LinearAlgebra.FreeModule.PID Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
@bors bors bot deleted the port/LinearAlgebra.FreeModule.Pid branch April 20, 2023 12:30
kbuzzard pushed a commit that referenced this pull request Apr 22, 2023
@xroblot @Parcly-Taxel @kbuzzard
feat: port LinearAlgebra.FreeModule.PID (#3434)
433ba2a 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request May 10, 2023
@xroblot @Parcly-Taxel
feat: port LinearAlgebra.FreeModule.PID (#3434)
833f676 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @semorrison @Parcly-Taxel