Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.FreeAbelianGroupFinsupp #3441

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.FreeAbelianGroupFinsupp #3441

wants to merge 8 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Apr 15, 2023

Open in Gitpod

@int-y1
feat: port GroupTheory.FreeAbelianGroupFinsupp
f305d89
@int-y1
Initial file copy from mathport
444760c
@int-y1
automated fixes
1030a3d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix
de69805
@int-y1
docs
f244ba1
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Apr 15, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 15, 2023 •
edited by Parcly-Taxel
Loading

todo:

  • toFinsupp_comp_toFreeAbelianGroup error

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Apr 15, 2023
eric-wieser

This comment was marked as resolved.

Sign in to view

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 15, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 15, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 17, 2023
bors bot pushed a commit that referenced this pull request Apr 17, 2023
@int-y1 @Parcly-Taxel
feat: port GroupTheory.FreeAbelianGroupFinsupp (#3441)
0a4bbec 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.FreeAbelianGroupFinsupp [Merged by Bors] - feat: port GroupTheory.FreeAbelianGroupFinsupp Apr 17, 2023
@bors bors bot closed this Apr 17, 2023
@bors bors bot deleted the port/GroupTheory.FreeAbelianGroupFinsupp branch April 17, 2023 08:52
semorrison pushed a commit that referenced this pull request May 10, 2023
@int-y1 @Parcly-Taxel
feat: port GroupTheory.FreeAbelianGroupFinsupp (#3441)
16367ab 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parcly-Taxel Parcly-Taxel Parcly-Taxel left review comments

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @jcommelin @eric-wieser @Parcly-Taxel