Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Localization.Ideal #3452

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Localization.Ideal #3452

wants to merge 19 commits into from

Conversation

EmilieUthaiwat
Copy link
Collaborator

Open in Gitpod

@EmilieUthaiwat EmilieUthaiwat added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 15, 2023
@EmilieUthaiwat EmilieUthaiwat marked this pull request as draft April 15, 2023 15:53
@EmilieUthaiwat EmilieUthaiwat changed the title Port/ring theory.localization.ideal feat: port RingTheory/Localization/Ideal Apr 15, 2023
@EmilieUthaiwat EmilieUthaiwat changed the title feat: port RingTheory/Localization/Ideal feat: port RingTheory.Localization.Ideal Apr 15, 2023
@Parcly-Taxel Parcly-Taxel marked this pull request as ready for review April 16, 2023 15:03
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 16, 2023
@EmilieUthaiwat EmilieUthaiwat removed the awaiting-review The author would like community review of the PR label Apr 16, 2023
@EmilieUthaiwat EmilieUthaiwat added awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR labels Apr 16, 2023
@Parcly-Taxel Parcly-Taxel added the awaiting-review The author would like community review of the PR label Apr 16, 2023
jcommelin
jcommelin reviewed Apr 17, 2023
View reviewed changes
Mathlib/RingTheory/Localization/Ideal.lean Outdated
@@ -167,14 +170,14 @@ variable {R : Type _} [CommRing R] (M : Submonoid R) (S : Type _) [CommRing S]

variable [Algebra R S] [IsLocalization M S]

include M
set_option maxHeartbeats 400000 in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please leave a porting note to explain why this is needed?
If you add set_option synthInstance.etaExperiment true, do you still need to increase the heartbeats?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tried adding set_option synthInstance.etaExperiment true but I still need to increase the heartbeats afterwards. Indeed, there is a timeout at line 203 (I do not understand why and I was about to ask on Zulip). Meanwhile, I have written a porting note to indicate that there was a timeout and where that timeout was.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 17, 2023
@EmilieUthaiwat EmilieUthaiwat added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 17, 2023
jcommelin
jcommelin approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 18, 2023
bors bot pushed a commit that referenced this pull request Apr 18, 2023
@EmilieUthaiwat @riccardobrasca @Ruben-VandeVelde
feat: port RingTheory.Localization.Ideal (#3452)
3e6e0fe 
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Apr 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port RingTheory.Localization.Ideal [Merged by Bors] - feat: port RingTheory.Localization.Ideal Apr 18, 2023
@bors bors bot closed this Apr 18, 2023
@bors bors bot deleted the port/RingTheory.Localization.Ideal branch April 18, 2023 06:05
semorrison pushed a commit that referenced this pull request May 10, 2023
@EmilieUthaiwat @riccardobrasca @Ruben-VandeVelde
feat: port RingTheory.Localization.Ideal (#3452)
9506d51 
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@EmilieUthaiwat @jcommelin @semorrison @Parcly-Taxel @riccardobrasca @Ruben-VandeVelde