Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.UrysohnsLemma #3490

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Topology.UrysohnsLemma #3490

wants to merge 11 commits into from

Conversation

lucasvreis
Copy link
Collaborator

@lucasvreis lucasvreis commented Apr 18, 2023 •
edited

It's my first mathlib PR, I hope I got it right.
(edit: sorry, I missed the step of asking for permission to assign labels in Zulip.)

Open in Gitpod

@lucasvreis lucasvreis added the mathlib-port This is a port of a theory file from mathlib. label Apr 18, 2023
@Parcly-Taxel Parcly-Taxel added the awaiting-review The author would like community review of the PR label Apr 18, 2023
@semorrison
Copy link
Contributor

@Parcly-Taxel, I think it was incorrect to restore (commented out) the @[protect_proj] attribute. @lucasvreis had already done the correct thing, using protected explicitly on the fields. Could you please revert that change?

@semorrison
Copy link
Contributor

Once the issue with protected is sorted out, you can merge, @lucasvreis!

bors d+

@bors
Copy link

bors bot commented Apr 18, 2023

✌️ lucasvreis can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel, I think it was incorrect to restore (commented out) the @[protect_proj] attribute. @lucasvreis had already done the correct thing, using protected explicitly on the fields. Could you please revert that change?

Right then, done.

@lucasvreis
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@lucasvreis @Parcly-Taxel
feat: port Topology.UrysohnsLemma (#3490)
b706a5f 
Co-authored-by: Lucas V. R <lvr@s-viva.xyz>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Topology.UrysohnsLemma [Merged by Bors] - feat: port Topology.UrysohnsLemma Apr 18, 2023
@bors bors bot closed this Apr 18, 2023
semorrison pushed a commit that referenced this pull request May 10, 2023
@lucasvreis @Parcly-Taxel
feat: port Topology.UrysohnsLemma (#3490)
d97f314 
Co-authored-by: Lucas V. R <lvr@s-viva.xyz>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasvreis @semorrison @Parcly-Taxel