[Merged by Bors] - fix: disable unsafe closed term extraction #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
added
the
awaiting-review
|
bors p=10 |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
The compiler extracts the closed term `Option.get none ◾` here, which causes a segfault in compiled code depending on mathlib, like e.g. mathport.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
May 10, 2023
The compiler extracts the closed term `Option.get none ◾` here, which causes a segfault in compiled code depending on mathlib, like e.g. mathport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler extracts the closed term
Option.get none ◾here, which causes a segfault in compiled code depending on mathlib, like e.g. mathport.This is currently breaking mathport updates.