Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(RingTheory/UniqueFactorizationDomain) : add lemma max_power_factor as in #18830 #3558

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(RingTheory/UniqueFactorizationDomain) : add lemma max_power_factor as in #18830 #3558

wants to merge 7 commits into from

Conversation

faenuccio
Copy link
Collaborator

@faenuccio faenuccio commented Apr 20, 2023 •
edited by eric-wieser

Add lemma max_powerFactor needed in leanprover-community/mathlib#18830 and modified there.

Open in Gitpod

@faenuccio faenuccio added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Apr 20, 2023
@faenuccio faenuccio added the awaiting-review The author would like community review of the PR label Apr 20, 2023
@eric-wieser eric-wieser added the forward-port-placeholder This is a "reminder" PR that the author of a mathlib3 PR will later turn into a forward-porting PR. label Apr 24, 2023
@eric-wieser eric-wieser removed the awaiting-review The author would like community review of the PR label Apr 24, 2023
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes needs-mathlib-SHA and removed forward-port-placeholder This is a "reminder" PR that the author of a mathlib3 PR will later turn into a forward-porting PR. labels May 6, 2023
Vierkantor
Vierkantor approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this is a faithful port of the changes, so LGTM. @faenuccio, are you planning any further modifications, with the awaiting-author status, or can we go ahead and merge this?

Mathlib/RingTheory/UniqueFactorizationDomain.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/UniqueFactorizationDomain.lean Outdated Show resolved Hide resolved
faenuccio and others added 2 commits May 10, 2023 11:02
@faenuccio @Vierkantor
Update Mathlib/RingTheory/UniqueFactorizationDomain.lean
45bc5cf 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@faenuccio @Vierkantor
Update Mathlib/RingTheory/UniqueFactorizationDomain.lean
fb61a92 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@faenuccio faenuccio removed the awaiting-author A reviewer has asked the author a question or requested changes label May 10, 2023
@faenuccio
Copy link
Collaborator Author

I checked that this is a faithful port of the changes, so LGTM. @faenuccio, are you planning any further modifications, with the awaiting-author status, or can we go ahead and merge this?

No, I do not plan any further modification and I have removed the awating-author label. You can go ahead (I have accepted+commited the two modifications suggested by @Vierkantor ).

@YaelDillies YaelDillies changed the title feat(RingTheory/UniqueFactorizationDomain) : add lemma max_powerFactor as in #18830 feat(RingTheory/UniqueFactorizationDomain) : add lemma max_power_factor as in #18830 May 10, 2023
@Vierkantor
Copy link
Contributor

In that case, Let's Get This Merged!

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 10, 2023
bors bot pushed a commit that referenced this pull request May 10, 2023
@faenuccio
feat(RingTheory/UniqueFactorizationDomain) : add lemma `max_power_fac…
2de98a0 
…tor` as in #18830 (#3558)

Add lemma `max_powerFactor` needed in leanprover-community/mathlib#18830 and modified there.
@bors
Copy link

bors bot commented May 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(RingTheory/UniqueFactorizationDomain) : add lemma max_power_factor as in #18830 [Merged by Bors] - feat(RingTheory/UniqueFactorizationDomain) : add lemma max_power_factor as in #18830 May 10, 2023
@bors bors bot closed this May 10, 2023
@bors bors bot deleted the PR_max_power_factor branch May 10, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@YaelDillies YaelDillies YaelDillies left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@faenuccio @Vierkantor @eric-wieser @YaelDillies