[Merged by Bors] - feat: make ListM safe
#3559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
added
awaiting-review
gebner
commented
Apr 21, 2023
| #check (rfl : ((ListM.fix F 10).takeAsList 4).run [] = some ([10, 9, 8, 7], [7, 8, 9, 10])) | ||
| #check (rfl : | ||
| (((ListM.fix F 10).map fun n => n*n).takeAsList 3).run [] = some ([100, 81, 64], [8, 9, 10])) | ||
| example : ((ListM.fix F 10).takeAsList 4).run [] = some ([10, 9, 8, 7], [8, 9, 10]) := by |
There was a problem hiding this comment.
There are two changes here:
rflno longer unfoldsListMoperations because they're partial and/or opaque. (But therflwasunsafeanyhow.)- I optimized
ListM.fixso that it requires fewer invocations ofFto produce the same number of elements. (That's why the second part of the pair---which stores each invocation ofF---got shorter.)
|
Oh my! This is amazing, thank you. bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ListM safeListM safe
kbuzzard
pushed a commit
that referenced
this pull request
Apr 22, 2023
semorrison
pushed a commit
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the unsafe inductive powering
ListMbehind a safe API usingimplemented_by.The motivation is of course Scott's recent barrage of library_search improvements using ListM which marks everything as unsafe. I'd really like to stop the proliferation of unsafe, so that unsafe continues to be a meaningful indicator of memory unsafety or logical unsoundness.