Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.String.Defs #3612

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Data.String.Defs #3612

wants to merge 4 commits into from

Conversation

chabulhwi
Copy link
Collaborator

  • Add isSuffixOf, isSuffixOf?, and getRest functions.
  • Add #align statements.
  • Indent function bodies.

Open in Gitpod

@chabulhwi
feat: port Data.String.Defs
fb703e4
@chabulhwi
Initial file copy from mathport
db32d4e
@chabulhwi
automated fixes
0bf7d4f 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@chabulhwi
fix code
f665be3 
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
@chabulhwi chabulhwi changed the title Port/data.string.defs feat: Port Data.String.Defs Apr 24, 2023
@chabulhwi chabulhwi changed the title feat: Port Data.String.Defs feat: port Data.String.Defs Apr 24, 2023
@chabulhwi chabulhwi self-assigned this Apr 24, 2023
@chabulhwi chabulhwi added awaiting-review mathlib-port This is a port of a theory file from mathlib. labels Apr 24, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 24, 2023
bors bot pushed a commit that referenced this pull request Apr 24, 2023
@chabulhwi
feat: port Data.String.Defs (#3612)
4ddd292 
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
@bors
Copy link

bors bot commented Apr 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.String.Defs [Merged by Bors] - feat: port Data.String.Defs Apr 24, 2023
@bors bors bot closed this Apr 24, 2023
@bors bors bot deleted the port/Data.String.Defs branch April 24, 2023 04:16
@chabulhwi chabulhwi self-assigned this Apr 24, 2023
semorrison pushed a commit that referenced this pull request May 10, 2023
@chabulhwi
feat: port Data.String.Defs (#3612)
6b5086b 
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
hrmacbeth pushed a commit that referenced this pull request May 10, 2023
@chabulhwi @hrmacbeth
feat: port Data.String.Defs (#3612)
ef0ca39 
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
hrmacbeth pushed a commit that referenced this pull request May 11, 2023
@chabulhwi @hrmacbeth
feat: port Data.String.Defs (#3612)
ef15fc6 
* Add `isSuffixOf`, `isSuffixOf?`, and `getRest` functions.
* Add `#align` statements.
* Indent function bodies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chabulhwi chabulhwi

Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chabulhwi @semorrison